Skip to content

Improve wording in Getting Started and other tutorials #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

davetcoleman
Copy link
Member

Currently we indicate MoveIt is being installed from debians, but this is no longer the case so I've made that clear in the tutorials. Should we change that back? Good question, I've created an issue here: #404

Also I don't love the usage of "quickly" at the top of every tutorial, as that is a relative judgement call depending on the experience level of the learner and the quality of our tutorials.

@davetcoleman davetcoleman force-pushed the pr-getting-started-cleanup branch from 36974ad to d75e932 Compare June 2, 2022 18:14
@davetcoleman davetcoleman marked this pull request as ready for review June 2, 2022 18:15
@davetcoleman
Copy link
Member Author

Also addressing feedback from @AndyZe here: #396

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wording, just left a few nits below

@davetcoleman davetcoleman force-pushed the pr-getting-started-cleanup branch from 4ed436d to f9aa09d Compare June 2, 2022 18:51
@davetcoleman davetcoleman added the backport-humble This label signals Mergify to backport this PR to Humble label Jun 2, 2022
@davetcoleman davetcoleman merged commit d71d784 into main Jun 2, 2022
@davetcoleman davetcoleman deleted the pr-getting-started-cleanup branch June 2, 2022 19:05
mergify bot pushed a commit that referenced this pull request Jun 2, 2022
* Improve wording in Getting Started and other tutorials

* Fixup

* Improve README

* Address PR feedback

(cherry picked from commit d71d784)

# Conflicts:
#	README.md
davetcoleman added a commit that referenced this pull request Jun 2, 2022
* Improve wording in Getting Started and other tutorials

* Fixup

* Improve README

* Address PR feedback

(cherry picked from commit d71d784)
davetcoleman added a commit that referenced this pull request Jun 2, 2022
#407)

* Improve wording in Getting Started and other tutorials (#405)

* Improve wording in Getting Started and other tutorials

* Fixup

* Improve README

* Address PR feedback

(cherry picked from commit d71d784)

* Switch from Rolling to Humble in text

Co-authored-by: Dave Coleman <[email protected]>
@tylerjw tylerjw mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label signals Mergify to backport this PR to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants