-
Notifications
You must be signed in to change notification settings - Fork 217
Improve wording in Getting Started and other tutorials #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36974ad
to
d75e932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the wording, just left a few nits below
AndyZe
approved these changes
Jun 2, 2022
4ed436d
to
f9aa09d
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Improve wording in Getting Started and other tutorials * Fixup * Improve README * Address PR feedback (cherry picked from commit d71d784) # Conflicts: # README.md
davetcoleman
added a commit
that referenced
this pull request
Jun 2, 2022
* Improve wording in Getting Started and other tutorials * Fixup * Improve README * Address PR feedback (cherry picked from commit d71d784)
davetcoleman
added a commit
that referenced
this pull request
Jun 2, 2022
#407) * Improve wording in Getting Started and other tutorials (#405) * Improve wording in Getting Started and other tutorials * Fixup * Improve README * Address PR feedback (cherry picked from commit d71d784) * Switch from Rolling to Humble in text Co-authored-by: Dave Coleman <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we indicate MoveIt is being installed from debians, but this is no longer the case so I've made that clear in the tutorials. Should we change that back? Good question, I've created an issue here: #404
Also I don't love the usage of "quickly" at the top of every tutorial, as that is a relative judgement call depending on the experience level of the learner and the quality of our tutorials.